Re: [PATCH 6/6] staging: ozwpan: Set AC_VO priority

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 20, 2012 at 01:36:11PM +0100, Rupesh Gujare wrote:
> Set packet priority to AC_VO for audio data.
> 
> Signed-off-by: Rupesh Gujare <rgujare@xxxxxxxxxxxxxxx>
> ---
>  drivers/staging/ozwpan/ozpd.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
> index 25a8a08..6c287ac 100644
> --- a/drivers/staging/ozwpan/ozpd.c
> +++ b/drivers/staging/ozwpan/ozpd.c
> @@ -815,6 +815,8 @@ int oz_send_isoc_unit(struct oz_pd *pd, u8 ep_num, u8 *data, int len)
>  		skb_reset_network_header(skb);
>  		skb->dev = dev;
>  		skb->protocol = htons(OZ_ETHERTYPE);
> +		/* For audio packet set priority to AC_VO */
> +		skb->priority = 0x7;

What is AC_VO?  The priorities should be declared in an enum in a
header file instead of using 0x7 hex throughout.  If the code said:

		skb->priority = AC_VO;

Then probably this wouldn't need a comment.  And I could just type
^] to find the answer to my questions.

regards,
dan carpenter

>  		size = sizeof(struct oz_hdr) + sizeof(struct oz_isoc_large);
>  		oz_hdr = (struct oz_hdr *)skb_put(skb, size);
>  	}
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux