Re: [PATCH 4/7] pstore/ram_core: Better ECC size checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 18, 2012 at 7:15 PM, Anton Vorontsov
<anton.vorontsov@xxxxxxxxxx> wrote:
> - Instead of exploiting unsigned overflows (which doesn't work for all
>  sizes), use straightforward checking for ECC total size not exceeding
>  initial buffer size;
>
> - Printing overflowed buffer_size is not informative. Instead, print
>  ecc_size and buffer_size;
>
> - No need for buffer_size argument in persistent_ram_init_ecc(),
>  we can address prz->buffer_size directly.
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov@xxxxxxxxxx>

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-- 
Kees Cook
Chrome OS Security
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux