On Mon, Jun 18, 2012 at 01:12:03PM +0200, Miguel Gómez wrote:
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -1376,8 +1376,10 @@ static int XGIfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
> vtotal = var->upper_margin + var->yres + var->lower_margin
> + var->vsync_len;
>
> - if (!(htotal) || !(vtotal))
> - XGIFAIL("XGIfb: no valid timing data");
> + if (!(htotal) || !(vtotal)) {
Don't resend this, but next time feel free to write this like:
if (!htotal || !vtotal) {
We do have a one change per patch rule but tiny formatting things
like that don't count as a change.
regards,
dan carpenter
> + pr_debug("XGIfb: no valid timing data\n");
> + return -EINVAL;
> + }
>
> if (var->pixclock && htotal && vtotal) {
> drate = 1000000000 / var->pixclock;
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
