Re: [PATCH 2/7] staging: nvec: use dev_warn instead of printk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 14, 2012 at 11:57:36PM +0200, Marc Dietrich wrote:
> Replace a printk in nvec core driver with dev_warn.
> 
> Signed-off-by: Marc Dietrich <marvin24@xxxxxx>
> ---
> -	printk(KERN_WARNING "unhandled msg type %ld\n", event_type);
> +	dev_warn(nvec->dev, "unhandled msg type %ld\n", event_type);
>  	print_hex_dump(KERN_WARNING, "payload: ", DUMP_PREFIX_NONE, 16, 1,
>  		msg, msg[1] + 2, true);

Is this stuff sensible at all? Now we have two lines, the first is
prefixed with the device, the second not, but both belong together.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux