On Thu, Jun 14, 2012 at 12:21:52AM +0200, Peter Huewe wrote:
> @@ -1565,15 +1548,15 @@ unsigned char XGIInitNew(struct pci_dev *pdev)
> /* Not DDR */
> xgifb_reg_set(pVBInfo->P3c4,
> 0x31,
> - (*pVBInfo->pSR31 & 0x3F) | 0x40);
> + (XGI330_SR31 & 0x3F) | 0x40);
You didn't introduce this, but Smatch complains about this and I
was wondering what was going on. XGI330_SR31 is 0xc0 and
(0xc0 & 0x3F) is zero. Probably the plan was to make XGI330_SR31
configurable?
regards,
dan carpenter
> xgifb_reg_set(pVBInfo->P3c4,
> 0x32,
> - (*pVBInfo->pSR32 & 0xFC) | 0x01);
> + (XGI330_SR32 & 0xFC) | 0x01);
> } else {
> - xgifb_reg_set(pVBInfo->P3c4, 0x31, *pVBInfo->pSR31);
> - xgifb_reg_set(pVBInfo->P3c4, 0x32, *pVBInfo->pSR32);
> + xgifb_reg_set(pVBInfo->P3c4, 0x31, XGI330_SR31);
> + xgifb_reg_set(pVBInfo->P3c4, 0x32, XGI330_SR32);
> }
> - xgifb_reg_set(pVBInfo->P3c4, 0x33, *pVBInfo->pSR33);
> + xgifb_reg_set(pVBInfo->P3c4, 0x33, XGI330_SR33);
> printk("17");
>
> /*
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
