On Wed, Jun 13, 2012 at 04:03:42PM -0500, Seth Jennings wrote:
> This patch fixes an uninitialized variable warning in
> alloc_zspage(). It also fixes the secondary issue of
> prev_page leaving scope on each loop iteration. The only
> reason this ever worked was because prev_page was occupying
> the same space on the stack on each iteration.
>
> Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
> drivers/staging/zsmalloc/zsmalloc-main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
> index fb54a9b..4af3dd6 100644
> --- a/drivers/staging/zsmalloc/zsmalloc-main.c
> +++ b/drivers/staging/zsmalloc/zsmalloc-main.c
> @@ -400,7 +400,7 @@ static void init_zspage(struct page *first_page, struct size_class *class)
> static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
> {
> int i, error;
> - struct page *first_page = NULL;
> + struct page *first_page = NULL, *uninitialized_var(prev_page);
>
> /*
> * Allocate individual pages and link them together as:
> @@ -415,7 +415,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
> */
> error = -ENOMEM;
> for (i = 0; i < class->pages_per_zspage; i++) {
> - struct page *page, *prev_page;
> + struct page *page;
>
> page = alloc_page(flags);
> if (!page)
> --
> 1.7.9.5
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
