On 2012/06/13 11:42 PM, H Hartley Sweeten wrote: > Refactor the subdev_8255_insn function to follow what the user > space library is doing. > > 1) This function requires 'data' to contain 2 parameters. Add a > sanity check for this (insn->n != 2). Actually, the comedi core will have already checked that. > 4) The user space library only checks for a < 0 return to indicate > an error. It appears that the 'return 2' in this function is supposed > to indicate the number of data parameters used to perform the command. > Return the insn->n value for this, the open coded '2' looks wrong. As long as it still returns 2, I don't care how you do it! -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
