Jonathan Nieder wrote:
> --- a/drivers/staging/zsmalloc/zsmalloc-main.c
> +++ b/drivers/staging/zsmalloc/zsmalloc-main.c
> @@ -471,13 +471,7 @@ static struct page *find_get_zspage(struct size_class *class)
> }
>
>
> -/*
> - * If this becomes a separate module, register zs_init() with
> - * module_init(), zs_exit with module_exit(), and remove zs_initialized
> -*/
> -static int zs_initialized;
> -
> -static int zs_cpu_notifier(struct notifier_block *nb, unsigned long action,
> +static int __init zs_cpu_notifier(struct notifier_block *nb, unsigned long action,
First review comment: the above shouldn't have __init, since it is
used after initialization, too. If testing, please drop the __init.
Here's a patch for squashing in.
Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
diff --git i/drivers/staging/zsmalloc/zsmalloc-main.c w/drivers/staging/zsmalloc/zsmalloc-main.c
index 4ba1911f97ff..2efd9d5ea29e 100644
--- i/drivers/staging/zsmalloc/zsmalloc-main.c
+++ w/drivers/staging/zsmalloc/zsmalloc-main.c
@@ -471,7 +471,7 @@ static struct page *find_get_zspage(struct size_class *class)
}
-static int __init zs_cpu_notifier(struct notifier_block *nb, unsigned long action,
+static int zs_cpu_notifier(struct notifier_block *nb, unsigned long action,
void *pcpu)
{
int cpu = (long)pcpu;
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
