On 2012/06/08 07:52 AM, Dan Carpenter wrote:
> This side of the if else statement returned with the lock held and IRQs
> disabled.
> --- a/drivers/staging/comedi/drivers/amplc_pci230.c
> +++ b/drivers/staging/comedi/drivers/amplc_pci230.c
> @@ -1387,6 +1387,8 @@ static int pci230_ao_inttrig_scan_begin(struct comedi_device *dev,
> /* Delay. Should driver be responsible for this? */
> /* XXX TODO: See if DAC busy bit can be used. */
> udelay(8);
> + } else {
> + spin_unlock_irqrestore(&devpriv->ao_stop_spinlock, irqflags);
> }
Thanks for catching that! I'll fix it in the out-of-kernel Comedi
sources as well.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
