I obviously spotted the bug from just reading the patch, but the bug could as well have been avoided by using the Smatch error checker. drivers/staging/slicoss/slicoss.c:1608 slic_cmdq_addcmdpage() error: potential NULL dereference 'pslic_handle'. drivers/staging/slicoss/slicoss.c:1608 slic_cmdq_addcmdpage() error: we previously assumed 'pslic_handle' could be null (see line 1606) So that's one way to avoid certain kinds of basic mistakes. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
