On Tue, Jun 05, 2012 at 03:10:29PM +0530, Sachin Kamat wrote: > On 05/06/2012, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Tue, Jun 05, 2012 at 01:56:43PM +0530, Sachin Kamat wrote: > >> Warnings reported by checkpatch.pl have been fixed. > >> > > > > If you use the pr_fmt macro then you can remove the "ashmem: " > > prefixes probably. > > pr_fmt macros do not append the module/function names to the fmt string. > Hence addition of module names (like ashmem) adds to readability. > I'm confused what you are saying here. Adding the module name is the whole point of the pr_fmt macro. You put it at the top of the file before the includes like this: #define pr_fmt(fmt) "ashmem: " fmt regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
