Re: [PATCH 1/2] Staging:winbond: Fix coding style issues in wb35tx.c This is a patch in wb35tx.c where spacing issues, unwanted braces & parenthesis, column width restrictions have all been fixed found by checkpatch.pl tool Signed-off-by: Vamsi Prasanth <vamsiprasanth@xxxxxxxxx>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 19, 2012 at 09:25:08PM +0800, vamsi prasanth wrote:
> ---
>  drivers/staging/winbond/wb35tx.c |   63 +++++++++++++++++++-------------------
>  1 file changed, 31 insertions(+), 32 deletions(-)

First off, interesting subject: you have there :)

Anyway, care to break this up into individual patches, each doing only
one thing?  You do a number of different things in this patch, which
isn't advised at all.

Care to resend it, after fixing up the Subject: mess as well (hint, you
need an extra line after the first line in the git commit, otherwise git
send-email messes things up.)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux