On Thu, May 31, 2012 at 02:50:12PM +0100, Ian Abbott wrote:
> On 2012-05-24 17:27, Ian Abbott wrote:
> >This replaces the set of 9 patches posted earlier to fix various
> >problems highlighted by Dan Carpenter and H Hartley Sweeten.
> >
> >The original PATCH 2/9 ("Check bus type is supported") has been changed to
> >one that moves I/O resource (de)allocation and PCI (en,dis)abling around
> >so das08_common_attach() and das08_common_detach() no longer care about
> >the bus type. This also makes the original PATCH 3/9 redundant, so the
> >following patches have been bumped up one place in the sequence.
> >
> >[PATCHv2 1/8] das08: Use IS_ENABLED()
> >[PATCHv2 2/8] das08: Move I/O resource (de)allocation.
> >[PATCHv2 3/8] das08: Use module_comedi_{pci_,}driver
> >[PATCHv2 4/8] das08: Remove forward function declarations.
> >[PATCHv2 5/8] das08: Replace printk calls
> >[PATCHv2 6/8] das08: Remove thisboard and devpriv macros
> >[PATCHv2 7/8] das08: Support multiple PCI card types
> >[PATCHv2 8/8] das08: Add attach_pci() hook
> >
> > drivers/staging/comedi/drivers/das08.c | 917 +++++++++++++++++---------------
> > 1 files changed, 478 insertions(+), 439 deletions(-)
>
> I can get rid of a lot of the #if stuff in this driver, but this
> will result in several compiler warnings about functions defined but
> not used. Which do people generally prefer, the warnings about
> unused functions or the #if stuff? (I could get rid of the compiler
> warnings by leaving more of the #if stuff in there.)
Complier warnings isn't good, but I think there is an __unused macro
that you might be able to use on those functions to keep it quiet. Care
to try that out?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
