On Tue, May 22, 2012 at 11:15:12AM +0100, Ian Abbott wrote: > On 2012-05-22 09:11, Dan Carpenter wrote: > >On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote: > >>@@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev, > >> if (ret< 0) > >> return ret; > >> > >>- devpriv->ioaddr = (void *)(unsigned long)it->options[0]; > >>+ devpriv->ioaddr = (void __iomem *)(unsigned long)it->options[0]; > > > > > >Obviously, your patch is fine, but I was wondering if it was a > >problem that it->options was only a 32 bit? Seems like it would > >deserve a comment. > > Yes, it's a bit of a strange driver, this one. It's a driver for a > module sitting on a PCI card, but there is no driver I know of for > the PCI card, and I've no idea what's actually ioremap'ing the > memory! > > Maybe we should quietly drop it and see if anyone complains? I'm all for deleting code :) Send me a patch removing it and I'll be glad to apply it. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
