Hi Adrian, Dan Carpenter wrote: > Nah. The original was better. Or you could do: > oz_trace("oz_elt_info_free: bad magic ei: %p magic: 0x%x\n", > ei, ei->magic); Like Dan I agree that the reformatting of the trace does not really make it easier to read. However, I accept the redundant checks on kfree() should be removed so agree with part of this patch. Kind regards Chris Kelly _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel