Re: [PATCH 2/2] Staging: zram: zram_drv: fix coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 28, 2012 at 11:55:16AM +0100, Adnan Ali wrote:
> The commit fixes coding style issue including
> long lines in driver.
> 
> Signed-off-by: Adnan Ali <adnan.ali@xxxxxxxxxxxxxxx>
> ---
>  drivers/staging/zram/zram_drv.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index 685d612..7639a8f 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -390,8 +390,9 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
>  		clen = PAGE_SIZE;
>  		page_store = alloc_page(GFP_NOIO | __GFP_HIGHMEM);
>  		if (unlikely(!page_store)) {
> -			pr_info("Error allocating memory for "
> -				"incompressible page: %u\n", index);
> +			pr_info(
> +			"Error allocating memory for incompressible page: %u\n",
> +									index);

Nah.  This isn't the right way to brack this up.  The parameter
should be indented.  Just leave it as is, the original is fine.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux