Hello Joe, On Mon, May 28, 2012 at 8:08 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Sun, 2012-05-27 at 22:30 -0400, Kevin McKinney wrote: >> Hi Devendra, >> >> On Sun, May 27, 2012 at 4:54 PM, Devendra Naga <devendra.aaru@xxxxxxxxx> wrote: >> > Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx> >> > --- >> > drivers/staging/bcm/Debug.h | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> I understand this is a simple change, but please add a descriptive >> change log to your patch for consistency. > > Hello as well. > > Devendra, sometimes the simpler change isn't the best change. > Consider converting some of these macros into functions. > So How about converting BCM_DEBUG_PRINT, BCM_DEBUG_PRINT_BUFFER, BCM_SHOW_DEBUG_BITMAP into a single function? and using a type to print the corresponding values? > Thanks, Devendra. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
