On 26/05/12 16:16, Michael Dabydeen wrote:
Fixed a coding style issue Signed-off-by: Michael Dabydeen<mdabydeen@xxxxxxxxx> --- drivers/staging/comedi/drivers/mpc8260cpm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/mpc8260cpm.c b/drivers/staging/comedi/drivers/mpc8260cpm.c index 364470e..6d291b7 100644 --- a/drivers/staging/comedi/drivers/mpc8260cpm.c +++ b/drivers/staging/comedi/drivers/mpc8260cpm.c @@ -36,7 +36,7 @@ It is apparently missing some code. #include "../comedidev.h" -extern unsigned long mpc8260_dio_reserved[4]; +unsigned long mpc8260_dio_reserved[4];
Since this driver is incomplete (since 2002) and mpc8260_dio_reserved[] in not referred to in the incomplete code, there's not enough information to tell if it should be extern or not.
We could just drop this source file from the kernel sources instead. It doesn't get built.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
