Re: [PATCH] staging: comedi: remove this_board macro in the s526 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 22, 2012 at 06:20:10PM -0700, H Hartley Sweeten wrote:
> The 'thisboard' macro depends on having a local variable with
> a magic name. The CodingStyle document suggests not doing this
> to avoid confusion. Remove the macro and use the comedi_board()
> inline helper to get the dev->board_ptr information.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Ian Abbott <abbotti@xxxxxxxxx>
> Cc: Mori Hess <fmhess@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> ---
> @@ -769,13 +765,7 @@ static int s526_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	}
>  	***/
>  
> -/*
> - * Initialize dev->board_name.  Note that we can use the "thisboard"
> - * macro now, since we just initialized it in the last line.
> - */
> -	dev->board_ptr = &s526_boards[0];

Was this intended?  Most of the boards have auto probing so the
->board_ptr gets set automatically.  We already called
comedi_board() so I wonder if the autoprobed board is the same as
the &s526_boards[0];?  NULL pointer perhaps?  I don't know.

> -
> -	dev->board_name = thisboard->name;
> +	dev->board_name = board->name;
>  
>  /*
>   * Allocate the private structure area.  alloc_private() is a

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux