On Tue, May 22, 2012 at 12:06:20AM -0400, Kevin McKinney wrote:
> This patch removes typedef for _TARGET_PARAMS,
> changes the name of the struct from
> _TARGET_PARAMS to bcm_target_params. In addition,
> remove typedefs: STARGETPARAMS, *PSTARGETPARAMS.
>
> Signed-off-by: Kevin McKinney <klmckinney1@xxxxxxxxx>
> ---
> drivers/staging/bcm/Adapter.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index 1d18ef9..f9d06c2 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -252,7 +252,7 @@ typedef struct _PER_TARANG_DATA {
> } PER_TARANG_DATA, *PPER_TARANG_DATA;
>
> #ifdef REL_4_1
> -typedef struct _TARGET_PARAMS {
> +struct bcm_target_params {
> B_UINT32 m_u32CfgVersion;
>
> /* Scanning Related Params */
> @@ -329,7 +329,7 @@ typedef struct _TARGET_PARAMS {
> * This is added just to sync 4.x and 5.x CFGs
> */
> B_UINT32 m_u32BandAMCEnable;
> -} STARGETPARAMS, *PSTARGETPARAMS;
> +};
> #endif
>
Obviously when I see something like this I think, "Hm... This is
either never used or the change will break the build." In this
case it's never used because REL_4_1 is never defined.
If you changed it, then you would have to redo the later patches in
this series. No one enjoys redoing patches and I don't enjoy
reviewing the same patches over and over.
Can you delete REL_4_1 code in a later patch?
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
