On 2012/05/17 02:32 PM, Greg KH wrote: > On Thu, May 17, 2012 at 07:45:08AM +0100, Ian Abbott wrote: >> On 17/05/12 07:15, H Hartley Sweeten wrote: >>> Wednesday, May 16, 2012 7:18 PM, Greg KH wrote: >>>> On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote: >>>>> Convert the struct addi_board initialization to C99 format and remove >>>>> all the NULL or 0 initializers. This makes maintaining and editing the >>>>> code simpler and less error prone. >>>> Nice job, this driver is a pain to read... >>> >>> Thanks. I agree... I've been avoiding the addi drivers until now. >>> Anytime a C file has an #include "something.c" it makes me >>> shudder... >>> >>> I've been thinking that the addi stuff should really be broken up >>> into some library modules with exported symbols for the individual >>> addi drivers to use. I need to look a bit closer at them to see if >>> this would work. Right now the whole thing is a bit of a mess. >> >> TBH, I don't know how they got accepted into Comedi in the first >> place. They tend to do their own thing as far as comedi instruction >> handling goes. I've no idea who's using them. It makes me shudder, >> too! Did I mention the use of floating point in some of their >> drivers that we had to disable? > > I thought a few years ago, either you, or someone else, said it would be > good to just delete them entirely. Or am I making that up and just wish > it would be so? :) I can't remember at my age! There was a guy who works for Addi-Data (Krauth Julien) who had trouble submitting patches to you directly (I was CC'd) back in September/October 2011, so I guess they'd be unhappy if the drivers were removed altogether! -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
