On Wed, 16 May 2012, K. Y. Srinivasan wrote:
> Set the hid drvdata prior to invoking hid_add_device() as hid_add_device()
> expects this state to be set. This bug was introduced in the recent hid
> changes that were made in:
>
> commit 07d9ab4f0e52cb2a383596e5ebbbd20232501393
> HID: hid-hyperv: Do not use hid_parse_report() directly
>
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> ---
> drivers/hid/hid-hyperv.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index 032e6c0..3d62781 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -516,11 +516,12 @@ static int mousevsc_probe(struct hv_device *device,
>
> sprintf(hid_dev->name, "%s", "Microsoft Vmbus HID-compliant Mouse");
>
> + hid_set_drvdata(hid_dev, device);
> +
> ret = hid_add_device(hid_dev);
> if (ret)
> goto probe_err1;
>
> - hid_set_drvdata(hid_dev, device);
>
> ret = hid_parse(hid_dev);
> if (ret) {
Applied, thanks KY.
--
Jiri Kosina
SUSE Labs
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
