On Fri, May 11, 2012 at 5:18 PM, Anton Vorontsov <anton.vorontsov@xxxxxxxxxx> wrote: > Since ramoops was converted to pstore, it has nothing to do with character > devices nowadays. Instead, today it is just a RAM backend for pstore. > > The patch just moves things around. There are a few changes were needed > because of the move: > > 1. Kconfig and Makefiles fixups, of course. > > 2. In pstore/ram.c we have to play a bit with MODULE_PARAM_PREFIX, this > is needed to keep user experience the same as with ramoops driver > (i.e. so that ramoops.foo kernel command line arguments would still > work). > > Signed-off-by: Anton Vorontsov <anton.vorontsov@xxxxxxxxxx> This consolidation seems good. I might prefer the move separated from the changes, just to make review easier, but I have no idea what that'll do to a bisect. :P > --- /dev/null > +++ b/fs/pstore/ram.c "ram.ko" seems like an awfully generic modbule name. Should this be called pstore_ram.* instead, like was done for the header file? And unless anyone objects, I have no problem letting the built-in name change too. > --- /dev/null > +++ b/include/linux/pstore_ram.h > @@ -0,0 +1,17 @@ > +#ifndef __RAMOOPS_H > +#define __RAMOOPS_H This define should probably change just to avoid confusion. -Kees -- Kees Cook Chrome OS Security _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
