On Mon, May 14, 2012 at 12:41:25PM +0200, Samuel Iglesias Gonsalvez wrote: > /* Read status register */ > - status_reg = readw((unsigned short *) (tpci200->info->interface_regs + > + status_reg = readw((void __iomem *) (tpci200->info->interface_regs + > TPCI200_STATUS_REG)); > Later in the patch, you do the right thing which is to declare this as an __iomem pointer in the header. The cast here can be removed and it all fits on one line. Remove it in a follow on patch if you want. Same for several of the other casts in this patch. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel