On Friday, May 11, 2012 11:00 AM, Greg KH wrote: > On Fri, May 11, 2012 at 10:07:43AM -0700, H Hartley Sweeten wrote: >> --- a/drivers/staging/comedi/drivers.c >> +++ b/drivers/staging/comedi/drivers.c <snip> >> +EXPORT_SYMBOL(comedi_pci_driver_register); <snip> >> +EXPORT_SYMBOL(comedi_pci_driver_unregister); > > EXPORT_SYMBOL_GPL() for these two functions? I wasn't sure about that... Question.. when "should" EXPORT_SYMBOL be used and when should it be EXPORT_SYMBOL_GPL? Also, do you have any comments on Ian Abbott's comment about the: > + pci_driver->name = comedi_driver->driver_name; In the register function? Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
