On Tue, 2012-05-08 at 10:15 +0200, Manohar Vanga wrote:
[...]
>
> Check whether the function exists or you could have trouble :)
> If you already added a check when registering to make sure this is always non-NULL then
> ignore this. I would recommend wrapping this up in some function:
>
> void tpci_slot_remove(struct tpci_slot *slot)
> {
> if (slot->dev->driver->ops->remove)
> slot->dev->driver->ops->remove(slot->dev);
> }
>
OK, I agree that this is better and clearer.
I am fixing some minor stuff I saw (one extra newline in ipack.h,
convert to "static" some functions, etc)
I hope this will increase the code quality and readability.
Thanks a lot for your reviews,
Sam
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
