Hey Samuel, > [snip] > > +#define to_ipack_dev(device) container_of(device, struct ipack_device, dev) > > [snip] > > +#define to_ipack_driver(drv) container_of(drv, struct ipack_driver, driver) These don't need to be public as only your bus driver uses them. You can move this into the .c file. -- /manohar _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel