> From: Randy Dunlap [mailto:rdunlap@xxxxxxxxxxxx] > Sent: Friday, April 27, 2012 6:38 PM > To: Seth Jennings > Cc: Greg Kroah-Hartman; devel@xxxxxxxxxxxxxxxxxxxx; Dan Magenheimer; Autif Khan; Konrad Rzeszutek > Wilk; linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; Robert Jennings; Nitin Gupta > Subject: Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency > > On 04/23/2012 06:33 PM, Seth Jennings wrote: > > > ZCACHE is a boolean in the Kconfig. When selected, it > > should require that CRYPTO be builtin (=y). > > > > Currently, ZCACHE=y and CRYPTO=m is a valid configuration > > when it should not be. > > > > This patch changes the zcache Kconfig to enforce this > > dependency. > > > > Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx> > > > Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> Not sure if you need my approval, but I just in case you are waiting for it: Acked-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> > > --- > > drivers/staging/zcache/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig > > index 3ed2c8f..7048e01 100644 > > --- a/drivers/staging/zcache/Kconfig > > +++ b/drivers/staging/zcache/Kconfig > > @@ -2,7 +2,7 @@ config ZCACHE > > bool "Dynamic compression of swap pages and clean pagecache pages" > > # X86 dependency is because zsmalloc uses non-portable pte/tlb > > # functions > > - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86 > > + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86 > > select ZSMALLOC > > select CRYPTO_LZO > > default n > > > > -- > ~Randy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
