staging/rtl8712: unhandled default case in SwLedOn function.

[joseph daniel <josephdanielwalter@xxxxxxxxx>]

Hi kernel developers,

In the function SwLedOn in rtl8712_led.c, we put the bLedOn = true,
even if its a default case. may be we need to return? or BUG()?.

the code listing is:

if ((padapter->bSurpriseRemoved == true) ||
        (padapter->bDriverStopped == true))
        return;
    LedCfg = r8712_read8(padapter, LEDCFG);
    switch (pLed->LedPin) {
    case LED_PIN_GPIO0:
        break;
    case LED_PIN_LED0:
        /* SW control led0 on.*/
        r8712_write8(padapter, LEDCFG, LedCfg&0xf0);
        break;
    case LED_PIN_LED1:
        /* SW control led1 on.*/
        r8712_write8(padapter, LEDCFG, LedCfg&0x0f);
        break;
    default:
        break;
    }
    pLed->bLedOn = true;

Thanks,
Dev.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel