On Tue, Apr 24, 2012 at 11:46:42AM -0700, Greg KH wrote: > On Tue, Apr 24, 2012 at 06:50:10PM +0200, Stéphane Pajot wrote: > > This is a patch to the ni_labpc.c file that fixes up trailing whitespace error and quoted string split across lines warning > > found by the checkpatch.pl tool > > Please only fix one type of thing per patch, so this should be a two > patch series at the least. Ok for that. > > But... > > > @@ -738,7 +738,7 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it) > > irq = it->options[1]; > > dma_chan = it->options[2]; > > #else > > - printk(KERN_ERR " this driver has not been built with ISA DMA " > > + printk(KERN_ERR " this driver has not been built with ISA DMA\n" > > "support.\n"); > > What? Why did you do this? Do you understand what you just did to the > message printed out? ... It was just to patch this "quoted string split across lines warning", i saw this solution on the web. Now i think i understand that i cannot modify AT ALL a printk(KERN_ERR* even if it's just with a \n ? Stef > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
