On Sat, Apr 21, 2012 at 10:41:00PM +0200, Jesper Juhl wrote:
> On Sat, 21 Apr 2012, Dan Carpenter wrote:
>
> > On Sat, Apr 21, 2012 at 08:33:15PM +0200, Jesper Juhl wrote:
> > > Just a trivial style cleanup.
> > >
> > > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> > > ---
> > > drivers/staging/olpc_dcon/olpc_dcon.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> > > index 7fe6eb6..992275c 100644
> > > --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> > > +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> > > @@ -134,7 +134,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int is_powered_down)
> > > power_up:
> > > if (is_powered_down) {
> > > x = 1;
> > > - x = olpc_ec_cmd(0x26, (unsigned char *) &x, 1, NULL, 0);
> > > + x = olpc_ec_cmd(0x26, (unsigned char *)&x, 1, NULL, 0);
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > This will only work on little endian systems btw. On big endian
> > systems the first byte is going to be 0x00 instead of 0x01.
> >
> Thank you, Dan, for bothering to take a look at this trivial patch.
>
Trivial patches are the easiest to review. ;)
> I hope we can agree that this issue is not affected by my trivial
> whitespace cleanup ;-) So, would you be OK with just leaving the patch
> alone for Greg to merge along with the others and then address this issue
> in a separate patch later?
>
Sure. That's not a problem.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
