Re: [PATCH V2 2/2] staging: iio: light: isl29018: use regmap for register access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/19/2012 10:59 AM, Laxman Dewangan wrote:
> [...]
> -static int isl29018_read_sensor_input(struct i2c_client *client, int mode)
> +static int isl29018_read_sensor_input(struct isl29018_chip *chip, int mode)
>  {
>  [...]
> -		dev_err(&client->dev, "Error in reading MSB DATA\n");
> +	status = regmap_read(chip->regmap, ISL29018_REG_ADD_DATA_MSB, &msb);
> +	if (status < 0) {
> +		dev_err(chip->dev,
> +			"Error in reading MSB DATA with error %d\n", status);
>  		return msb;

should return status instead of msb.

> [...]
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux