rtl8192e, question about rtllib_MlmeDisassociateRequest()

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hi Larry,

I had a question about this code.  I'm not sure what is intended.  It's
from drivers/staging/rtl8192e/rtllib_softmac.c

void rtllib_MlmeDisassociateRequest(struct rtllib_device *rtllib, u8 *asSta,
                                    u8 asRsn)
{
        u8 i;
        u8      OpMode;

        RemovePeerTS(rtllib, asSta);


        if (memcpy(rtllib->current_network.bssid, asSta, 6) == NULL) {
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
memcpy() returns a pointer to the dest, so if it returns NULL here then
we have already Oopsed.  Was memcmp() intended?

                rtllib->state = RTLLIB_NOLINK;

                for (i = 0; i < 6; i++)
                        rtllib->current_network.bssid[i] = 0x22;
                OpMode = RT_OP_MODE_NO_LINK;
                rtllib->OpMode = RT_OP_MODE_NO_LINK;
                rtllib->SetHwRegHandler(rtllib->dev, HW_VAR_MEDIA_STATUS,
                                        (u8 *)(&OpMode));
                rtllib_disassociate(rtllib);

                rtllib->SetHwRegHandler(rtllib->dev, HW_VAR_BSSID,
                                        rtllib->current_network.bssid);

        }

}

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel