On Tue, Apr 17, 2012 at 07:08:20PM +0200, Roland Stigge wrote: > @@ -435,6 +436,7 @@ static int __devinit usb_hcd_nxp_probe(s > } > > __raw_writel(__raw_readl(USB_CTRL) | USB_HOST_NEED_CLK_EN, USB_CTRL); > + __raw_writel(__raw_readl(USB_CTRL) & ~USB_DEV_NEED_CLK_EN, USB_CTRL); > > /* Set to enable all needed USB clocks */ > __raw_writel(USB_CLOCK_MASK, USB_OTG_CLK_CTRL); What does this chunk do? Is this part of the "* Fixed controller initialization (bits)" bullet point? How does it affect the user? Should it be included in the 3.4 kernel? Generally bug fixes, cleanups, and new features should go into different patches. If you use "git citool" then you can highlight and right click on the lines you want to go into the patch. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
