On Wed, Apr 11, 2012 at 03:27:35PM -0500, Matt Renzelmann wrote: > Hello, > > I've never submitted a patch before or posted to a kernel mailing list, so I > hope I've done everything necessary. The following patch is against Linus's > tree. Please let me know if I've screwed anything up, or if this is not a > genuine bug. First off, you might want to send it to the author of the driver, and the maintainer of the subsystem, and the mailing list for that area. That can be found using the scripts/get_maintainer.pl tool: $ ./scripts/get_maintainer.pl --file drivers/leds/leds-lp5523.c Richard Purdie <rpurdie@xxxxxxxxx> (maintainer:LED SUBSYSTEM) linux-kernel@xxxxxxxxxxxxxxx (open list) > > Thanks and regards, > Matt > > ================= > > The lp5523_attributes array is missing a null-terminator. This patch > adds it. > > Signed-off-by: Matt Renzelmann <mjr@xxxxxxxxxxx> This line, and this changelog comment needs to go down further below: > --- > >From 3dae6f19c86ede0edeeea499e592b640e42e811a Mon Sep 17 00:00:00 2001 > From: Matt Renzelmann <mjr@xxxxxxxxxxx> > Date: Wed, 11 Apr 2012 15:04:38 -0500 > Subject: [PATCH] Missing attribute list NULL terminator The stuff above with the signed off-by line goes right here. And don't include the git patch in your message, use 'git send-email' to send the patch to the right people, that will format it properly and keep the '>From' stuff from being in there and requiring the maintainer to edit the email before they can apply it. And yes, this does look like a valid bugfix, nice job. So, care to fix the format of this up and send it off to Richard? Hope this helps, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
