On 4/10/12, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Mar 19, 2012 at 09:50:10PM +0400, Dmitry Eremin-Solenikov wrote: >> There is no need for mtrr value or any code around it if the kernel is >> built w/o CONFIG_MTRR. For code cleanup move data member under >> CONFIG_MTRR ifdef. > > That's not a valid "code cleanup". We don't like #ifdefs in .c files, > and as this does not cause any problems as-is, it should be left alone. > > So, sorry, I'm not going to accept this patch. No problem, thank you for taking the rest of the patches. Anyway this patch needs to be redone, as the original code is erroneous. -- With best wishes Dmitry _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
