Am Freitag, 16. März 2012, 17:23:58 schrieb santosh nayak: > From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx> > > In s2250_probe(), If locking attempt is interrupted by a signal then > it should return -EINTR after unregistering audio device and making free > the allocated memory. > > At present, if locking is interrupted by signal it will display message > "initialized successfully" and return success. This is wrong. Indeed there's a lot wrong here. The idea of having an interruptible sleep in probe() is arcane. You need a very, very, very good reason for that. The sane fix is using an uninterruptable sleep here. Second, while you are at it, fix the error case for no initialization due to a failing kmalloc(). You need to return -ENOMEM. Regards Oliver _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
