On Sun, Mar 11, 2012 at 10:00:54PM +0100, Jörg Sommer wrote:
> As the description of WARN_ON_SMP in bug.h says, one can not use
> spin_is_locked() in assertions for non‐SMP configurations, because it
> always returns the lock is not held. Otherwise a warning is thrown
> everytime on a uniprocessor system.
> ---
> drivers/staging/zcache/tmem.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/tmem.h b/drivers/staging/zcache/tmem.h
> index ed147c4..b543694 100644
> --- a/drivers/staging/zcache/tmem.h
> +++ b/drivers/staging/zcache/tmem.h
> @@ -47,7 +47,7 @@
> #define ASSERT_INVERTED_SENTINEL(_x, _y) do { } while (0)
> #endif
>
> -#define ASSERT_SPINLOCK(_l) WARN_ON(!spin_is_locked(_l))
> +#define ASSERT_SPINLOCK(_l) WARN_ON_SMP(!spin_is_locked(_l))
Why do we even have asserts in this code in the first place? Shouldn't
they all be removed by now?
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
