On Fri, Feb 24, 2012 at 5:49 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > This is nice, but, as this is a driver, I really prefer the use of > dev_err() instead, which allows us to properly identify the device and > driver that spit out the error message. Care to redo this patch in that > style instead? > > thanks, > > greg k-h sure, I can do this. but first, there is something wrong about the structure dependencies on the headers: now, the usage of the dev_err() breaks the build. for example: dev_err(&ctx->adp->pdev->dev, " ..."); on crystalhd_cmds.c returns the error: dereferencing pointer to incomplete type. I will fix this and send it all on another series. -- Regards, Jorgyano Vieira _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
