These are each >20k LOC drivers that embed an entire SD stack, and present SD cards as if they were SCSI devices; both drivers should be rewritten to be small hooks that connect the PCI (for rts_pstor) or USB (for rts5139) hardware into Linux's MMC/xD/memorystick stacks. Signed-off-by: Chris Ball <cjb@xxxxxxxxxx> Cc: edwin_rong <edwin_rong@xxxxxxxxxxxxxx> --- drivers/staging/rts5139/TODO | 6 +++++- drivers/staging/rts_pstor/TODO | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5139/TODO b/drivers/staging/rts5139/TODO index 4bde726..dd5fabb 100644 --- a/drivers/staging/rts5139/TODO +++ b/drivers/staging/rts5139/TODO @@ -2,4 +2,8 @@ TODO: - support more USB card reader of Realtek family - use kernel coding style - checkpatch.pl fixes - +- stop having thousands of lines of code duplicated with staging/rts_pstor +- This driver contains an entire SD/MMC stack -- it should use the stack in + drivers/mmc instead, as a host driver e.g. drivers/mmc/host/realtek-usb.c; + see drivers/mmc/host/ushc.c as an example. +- This driver presents cards as SCSI devices, but they should be MMC devices. diff --git a/drivers/staging/rts_pstor/TODO b/drivers/staging/rts_pstor/TODO index 2f93a7c..becb95e 100644 --- a/drivers/staging/rts_pstor/TODO +++ b/drivers/staging/rts_pstor/TODO @@ -2,4 +2,8 @@ TODO: - support more pcie card reader of Realtek family - use kernel coding style - checkpatch.pl fixes - +- stop having thousands of lines of code duplicated with staging/rts5139 +- This driver contains an entire SD/MMC stack -- it should use the stack in + drivers/mmc instead, as a host driver e.g. drivers/mmc/host/realtek-pci.c; + see drivers/mmc/host/via-sdmmc.c as an example. +- This driver presents cards as SCSI devices, but they should be MMC devices. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
