On Tue, Feb 21, 2012 at 12:13:40AM +0530, Pradheep Shrinivasan wrote: > Hi Dan > > I remember the bug .. but i think in this case it would be ok as it does > not look that weird as in the case of the single character brackets. > > In case you feel it is totally un necessary i can fix it and send the patch > again. So are you asking me, are the parenthesis totally unnecessary? Yes. Absolutely. How could that macro possibly be expanded in a way that would cause a bug. Are you asking me if I think the code is better without unneeded parenthesis? Yes again. Are you asking me if I'm going to NAK your patch? No. It's an unfortunate thing. Checkpatch.pl is going around telling people to add bogus parenthesis everywhere, and no one likes to redo their patches. And I feel like a jerk for telling people that they should redo their patches. And checkpatch.pl is a robot which has more energy than I do. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
