Re: [staging-next V2] staging/mei: mei-amt-version - make all function static and used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 20, 2012 at 02:46:03PM +0200, Tomas Winkler wrote:
> This patch eliminates following type of warnings
> warning: no previous prototype for '...func...' [-Wmissing-prototypes]
> 
> For this is a single file example lets make all API-like functions
> be static.
> Since all static functions should be used so let's call
> to amt_host_if_deinit() even if in this example it's not really necessary
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>

Cool.  Looks good.

Acked-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux