Re: [staging-next] staging/mei: mei-amt-version - make all function static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 20, 2012 at 11:54:46AM +0200, Tomas Winkler wrote:
> since this is a single file example make also API-like function
> static and used to remove compilation warnings.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>

[ snip ]

> @@ -455,6 +455,8 @@ int main(int argc, char **argv)
>  
>  	status = amt_get_code_versions(&acmd, &ver);
>  
> +	amt_host_if_deinit(&acmd);
> +

The changelog sucks.  What is the effect of this change?  Why don't
we just delete the function instead?

regards,
dan carpenter


Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux