On Sun, Feb 19, 2012 at 07:56:22PM -0300, Ezequiel García wrote: > Hi, > > 2012/2/18 Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > > The first line of the comment here should be a blank line. > > Ok. > > > > > /* > > * blah blah blah > > * blah blah blah > > */ > > > >> + /* A new struct easycap is always allocated when interface 0 is probed. > >> + * It is not possible here to free any existing struct easycap. > >> + * This should have been done by easycap_delete() when the device was > >> + * physically unplugged. > >> + * The allocated struct easycap is saved for later usage when > >> + * interfaces 1 and 2 are probed. > >> + */ > > ^ > > Could you make this asterisk line up with the others? > > Of course. > > If I send more patches about easycap driver, can I base it on my > current local branch? > I mean, based on all these patches? > Yeah. I don't really mind. If you want to fix these in a later patch that's ok by me. I just wanted to explain how multi-line comments are supposed to look so you get it right in later patches. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
