On Sun, Feb 12, 2012 at 09:09:05PM +0100, Roland Stigge wrote: > This patch adds a 3-channel ADC driver for the LPC32xx ARM SoC > > Signed-off-by: Roland Stigge <stigge@xxxxxxxxx> You need to split the mach-specific stuff and the driver, then submit them seperately via the respective maintainers. > Index: linux-arm-soc/arch/arm/mach-lpc32xx/phy3250.c > =================================================================== > --- linux-arm-soc.orig/arch/arm/mach-lpc32xx/phy3250.c 2012-02-12 20:04:49.000000000 +0100 > +++ linux-arm-soc/arch/arm/mach-lpc32xx/phy3250.c 2012-02-12 20:17:13.000000000 +0100 > @@ -252,6 +252,9 @@ > &lpc32xx_i2c2_device, > &lpc32xx_watchdog_device, > &lpc32xx_gpio_led_device, > +#if defined(CONFIG_LPC32XX_ADC) > + &lpc32xx_adc_device, > +#endif Probably personal taste, yet I'd skip the #ifdef. The rest of the mach stuff looks fine to me. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
