Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> > I'll take this, but you do know there is no reason for this, as these
> > are static functions.  I'd recommend keeping them as short as possible,
> > but hey, it's not my code...
> > 
> > thanks,
> > 
> > greg k-h
> 
> I agree with Greg on this one. At the time I didn't prefix these
> functions with the module name because I wanted to make them clear they
> were different. The difference lies in the fact that those functions
> are only used to implement the sysfs interface.

Yeah, maybe you are right. I thought it was just an oversight. I can send a 
patch that will get orig names back if you prefer.


-- 
Szymon K. Janc
szymon@xxxxxxxxxxx

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux