Re: [PATCH v2 00/17] Some work on quickstart driver in staging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> Ok, I think I got the right ones, please check that I did.

Those 2 (minor) are still not applied

Staging: quickstart: Use scnprintf in quickstart_pressed_button_show
Staging: quickstart: Bump driver version to 1.04

> Also, you just created the following build warning, please send me a
> patch fixing it up:
> 
> drivers/staging/quickstart/quickstart.c: In function
> ‘quickstart_acpi_ghid’: drivers/staging/quickstart/quickstart.c:212:5:
> warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument
> 3 has type ‘acpi_size’ [-Wformat]

acpi_size is u32 or u64 depending on arch, is it ok to just cast it to 
unsigned int for printing?

-- 
Szymon K. Janc
szymon@xxxxxxxxxxx

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux