> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday, February 02, 2012 6:30 PM > To: KY Srinivasan > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; ohering@xxxxxxxx; > zbr@xxxxxxxxxxx; Haiyang Zhang > Subject: Re: [PATCH 3/6] drivers: hv: Cleanup the kvp related state in hyperv.h > > On Fri, Jan 27, 2012 at 03:55:59PM -0800, K. Y. Srinivasan wrote: > > Now cleanup the hyperv.h with regards to KVP definitions. > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > include/linux/hyperv.h | 32 +++++++++++++++++++------------- > > 1 files changed, 19 insertions(+), 13 deletions(-) > > > > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h > > index 7332b3f..802ece8 100644 > > --- a/include/linux/hyperv.h > > +++ b/include/linux/hyperv.h > > @@ -137,7 +137,6 @@ struct hv_ku_msg { > > > > > > > > -#ifdef __KERNEL__ > > > > /* > > * Registry value types. > > @@ -162,29 +161,36 @@ enum hv_kvp_exchg_pool { > > KVP_POOL_COUNT /* Number of pools, must be last. */ > > }; > > > > +#ifndef __packed > > +#define __packed __attribute__((packed)) > > +#endif > > Why do this? > > If you are so worried about this in userspace, then just change the > values below to __attribute__((packed)), like all of the other public .h > files do. Greg, When I ran the checkpatch script against these patches I got a warning that the preferred directive was to use "__packed". So, for the header file that will be consumed in the kernel, I chose to go with the __packed. For inclusion of this header file in the user space daemon, I put in this definition here. So rather than having numerous warnings, I now have a single warning. If you prefer, I can move this definition to the daemon code where it is really needed. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
