On 02/02/2012 07:20 AM, Dan Carpenter wrote: > On Wed, Feb 01, 2012 at 07:45:55PM +0100, Lars-Peter Clausen wrote: >> We always hold the waitqueue lock when modifying the flags field. So it is safe >> to use the non-atomic bitops here instead of the atomic versions. >> >> The lock has to be held, because we need to clear the busy flag and flush the >> event fifo in one atomic operation when closing the event file descriptor. >> > > Is the performance improvement worth it? > I don't think there is any real performance improvement to be expected of this patch. If you have good a reason why non-atomic bitops should not be used I guess this patch could be dropped. But right now I don't see anything wrong with it. Thanks, - Lars _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
