Re: [PATCH 1/2] Staging: android: binder: Add some error checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 21, 2012 at 11:22:08AM +0300, Dan Carpenter wrote:
> On Fri, Jan 20, 2012 at 07:56:20PM -0800, Arve Hjønnevåg wrote:
> > - Add a mutex to protect against two processes mmapping the
> >   same binder_proc.
> > - After locking mmap_sem, check that the vma we want to access
> >   (still) points to the same mm_struct.
> > - Use proc->tsk instead of current to get the files struct since
> >   this is where we get the rlimit from.
> 
> This doesn't seem related to the locking change at all.  Probably
> this patch should be split into three patches, one bugfix per
> patch, unless they are very closely related.

I agree.  Arve, is this all fixing one problem, or multiple ones?  If
multiple ones, we need this split up into multiple patches.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux